Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 741993002: Quote the path to IE when launching it for the uninstall survey. (Closed)

Created:
6 years, 1 month ago by grt (UTC plus 2)
Modified:
6 years, 1 month ago
Reviewers:
gab
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Quote the path to IE when launching it for the uninstall survey. BUG=434964 R=gab@chromium.org Committed: https://crrev.com/bf5ba14fbc8a1dbe23b6132a15551f8d9e36dba1 Cr-Commit-Position: refs/heads/master@{#305011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
grt (UTC plus 2)
Hi Gab. Please take a look at this minimal change to fix a security bugaboo. ...
6 years, 1 month ago (2014-11-20 03:49:38 UTC) #1
gab
lgtm, but I agree that this code should use CommandLine instead.
6 years, 1 month ago (2014-11-20 13:21:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741993002/1
6 years, 1 month ago (2014-11-20 13:51:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 14:38:57 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 14:39:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf5ba14fbc8a1dbe23b6132a15551f8d9e36dba1
Cr-Commit-Position: refs/heads/master@{#305011}

Powered by Google App Engine
This is Rietveld 408576698