Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: mojo/edk/system/channel_endpoint.cc

Issue 741983003: Make ChannelEndpoint::OnReadMessage() take a MessageInTransit instead of a MessageInTransit::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/channel_endpoint.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/channel_endpoint.cc
diff --git a/mojo/edk/system/channel_endpoint.cc b/mojo/edk/system/channel_endpoint.cc
index ca86b5f92d55f868f5355ea5f34ef531a3ba2ce5..f11290ea8dbde9869f0f25af1781a018f898a617 100644
--- a/mojo/edk/system/channel_endpoint.cc
+++ b/mojo/edk/system/channel_endpoint.cc
@@ -7,7 +7,6 @@
#include "base/logging.h"
#include "mojo/edk/system/channel.h"
#include "mojo/edk/system/channel_endpoint_client.h"
-#include "mojo/edk/system/transport_data.h"
namespace mojo {
namespace system {
@@ -85,10 +84,7 @@ void ChannelEndpoint::AttachAndRun(Channel* channel,
}
}
-bool ChannelEndpoint::OnReadMessage(
- const MessageInTransit::View& message_view,
- embedder::ScopedPlatformHandleVectorPtr platform_handles) {
- scoped_ptr<MessageInTransit> message(new MessageInTransit(message_view));
+bool ChannelEndpoint::OnReadMessage(scoped_ptr<MessageInTransit> message) {
scoped_refptr<ChannelEndpointClient> client;
unsigned client_port;
{
@@ -100,14 +96,6 @@ bool ChannelEndpoint::OnReadMessage(
return true;
}
- if (message_view.transport_data_buffer_size() > 0) {
- DCHECK(message_view.transport_data_buffer());
- message->SetDispatchers(TransportData::DeserializeDispatchers(
- message_view.transport_data_buffer(),
- message_view.transport_data_buffer_size(), platform_handles.Pass(),
- channel_));
- }
-
// Take a ref, and call |OnReadMessage()| outside the lock.
client = client_;
client_port = client_port_;
« no previous file with comments | « mojo/edk/system/channel_endpoint.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698