Issue 741983003: Make ChannelEndpoint::OnReadMessage() take a MessageInTransit instead of a MessageInTransit::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 741983003: Make ChannelEndpoint::OnReadMessage() take a MessageInTransit instead of a MessageInTransit::View. (Closed)

Created:
6 years, 1 month ago by viettrungluu

Modified:
6 years ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make ChannelEndpoint::OnReadMessage() take a MessageInTransit instead of a MessageInTransit::View. It's a bit cleaner, and equally significantly this means that TransportData::DeserializeDispatchers() no longer gets called under ChannelEndpoint's lock, which is a bit bad since it may call into Channel which may theoretically (but not likely) in turn call into ChannelEndpoint. Admittedly, this could be accomplished without moving the MessageInTransit::View -> MessageInTransit conversion into Channel. R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/81b582f392619f376c2a397fccf69e0e2a281008

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -19 lines)			Patch
M	mojo/edk/system/channel.cc	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	mojo/edk/system/channel_endpoint.h	View	2 chunks	+1 line, -4 lines	0 comments	Download
M	mojo/edk/system/channel_endpoint.cc	View	3 chunks	+1 line, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years ago (2014-11-26 03:45:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
81b582f392619f376c2a397fccf69e0e2a281008 (presubmit successful).

Expand Messages | Collapse Messages