Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 741943003: Fix disable_nacl=1 build of browser_tests (Closed)

Created:
6 years, 1 month ago by hans
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix disable_nacl=1 build of browser_tests BUG=none Committed: https://crrev.com/6f06cdc44ae71c7fde0cb916e0c28aeed5394d37 Cr-Commit-Position: refs/heads/master@{#305061}

Patch Set 1 #

Patch Set 2 : Actually, make these flags unavailable at compile-time too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/common/nacl_switches.h View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hans
Please take a look.
6 years, 1 month ago (2014-11-20 17:54:21 UTC) #2
dmichael (off chromium)
lgtm
6 years, 1 month ago (2014-11-20 18:14:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741943003/20001
6 years, 1 month ago (2014-11-20 18:17:43 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-20 19:36:47 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:37:45 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f06cdc44ae71c7fde0cb916e0c28aeed5394d37
Cr-Commit-Position: refs/heads/master@{#305061}

Powered by Google App Engine
This is Rietveld 408576698