Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 74193005: Add extra warnings to match what Android uses. (Closed)

Created:
7 years, 1 month ago by djsollen
Modified:
7 years, 1 month ago
Reviewers:
mtklein, bsalomon, brian1, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressing comments #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M gyp/common_conditions.gypi View 1 2 3 3 chunks +16 lines, -13 lines 0 comments Download
M gyp/poppler.gyp View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 1 3 chunks +3 lines, -10 lines 0 comments Download
M src/animator/SkScriptCallBack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkBuffer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.h View 3 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
djsollen
7 years, 1 month ago (2013-11-18 21:19:13 UTC) #1
mtklein
https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi#newcode245 gyp/common_conditions.gypi:245: '-Wno-c++11-extensions', Move this guy up too and get rid ...
7 years, 1 month ago (2013-11-18 21:21:56 UTC) #2
djsollen
https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi#newcode245 gyp/common_conditions.gypi:245: '-Wno-c++11-extensions', On 2013/11/18 21:21:56, mtklein wrote: > Move this ...
7 years, 1 month ago (2013-11-18 21:34:03 UTC) #3
brian1
On 2013/11/18 21:34:03, djsollen wrote: > https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi > File gyp/common_conditions.gypi (right): > > https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi#newcode245 > ...
7 years, 1 month ago (2013-11-18 21:38:05 UTC) #4
mtklein
lgtm
7 years, 1 month ago (2013-11-18 21:46:04 UTC) #5
djsollen
Committed patchset #4 manually as r12310 (presubmit successful).
7 years, 1 month ago (2013-11-20 13:16:52 UTC) #6
mtklein
7 years, 1 month ago (2013-11-20 15:13:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r12314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698