Add extra warnings to match what Android uses.

Add extra warnings to match what Android uses.

R=mtklein@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12310

Committed: https://code.google.com/p/skia/source/detail?r=12314

[mtklein, 2013-11-18 21:21:56]

https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi#ne...
gyp/common_conditions.gypi:245: '-Wno-c++11-extensions',
Move this guy up too and get rid of this block?

https://codereview.chromium.org/74193005/diff/1/platform_tools/android/gyp/de...
File platform_tools/android/gyp/dependencies.gypi (right):

https://codereview.chromium.org/74193005/diff/1/platform_tools/android/gyp/de...
platform_tools/android/gyp/dependencies.gypi:74: '-Wextra',
Maybe just cflags: [ '-w' ] these guys?

[djsollen, 2013-11-18 21:34:03]

https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi#ne...
gyp/common_conditions.gypi:245: '-Wno-c++11-extensions',
On 2013/11/18 21:21:56, mtklein wrote:
> Move this guy up too and get rid of this block?

Done.

https://codereview.chromium.org/74193005/diff/1/platform_tools/android/gyp/de...
File platform_tools/android/gyp/dependencies.gypi (right):

https://codereview.chromium.org/74193005/diff/1/platform_tools/android/gyp/de...
platform_tools/android/gyp/dependencies.gypi:74: '-Wextra',
On 2013/11/18 21:21:56, mtklein wrote:
> Maybe just cflags: [ '-w' ] these guys?

Done.

[brian1, 2013-11-18 21:38:05]

On 2013/11/18 21:34:03, djsollen wrote:
> https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi
> File gyp/common_conditions.gypi (right):
> 
>
https://codereview.chromium.org/74193005/diff/1/gyp/common_conditions.gypi#ne...
> gyp/common_conditions.gypi:245: '-Wno-c++11-extensions',
> On 2013/11/18 21:21:56, mtklein wrote:
> > Move this guy up too and get rid of this block?
> 
> Done.
> 
>
https://codereview.chromium.org/74193005/diff/1/platform_tools/android/gyp/de...
> File platform_tools/android/gyp/dependencies.gypi (right):
> 
>
https://codereview.chromium.org/74193005/diff/1/platform_tools/android/gyp/de...
> platform_tools/android/gyp/dependencies.gypi:74: '-Wextra',
> On 2013/11/18 21:21:56, mtklein wrote:
> > Maybe just cflags: [ '-w' ] these guys?
> 
> Done.

GPU lgtm

[mtklein, 2013-11-18 21:46:04]

lgtm

[djsollen, 2013-11-20 13:16:52]

Committed patchset #4 manually as r12310 (presubmit successful).

[mtklein, 2013-11-20 15:13:54]

Committed patchset #4 manually as r12314 (presubmit successful).