Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 741903002: Attempt #5 at converting telemetry to use typ :). (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Attempt #5 at converting telemetry to use typ :). This version should fix all the issues with chrome_proxy that thwarted versions #3 and #4 ... TBR=dtu@chromium.org BUG=388256 Committed: https://crrev.com/7aa15ac741fbaf565ca0df43cf11e83e44b4b99e Cr-Commit-Position: refs/heads/master@{#304964}

Patch Set 1 : initial broken patch from #4 #

Patch Set 2 : partial "quick fix" for chrome_proxy (still broken) #

Patch Set 3 : telemetry-side fix needed to actually fix chrome_proxy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -520 lines) Patch
M tools/chrome_proxy/run_tests View 1 1 chunk +14 lines, -10 lines 0 comments Download
M tools/perf/run_tests View 1 chunk +13 lines, -9 lines 0 comments Download
M tools/telemetry/PRESUBMIT.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +17 lines, -30 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +13 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 3 chunks +63 lines, -15 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/browser_test_case.py View 1 chunk +33 lines, -12 lines 0 comments Download
D tools/telemetry/telemetry/unittest_util/json_results.py View 1 chunk +0 lines, -247 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_chromeos_tests.py View 2 chunks +18 lines, -26 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests.py View 1 2 4 chunks +115 lines, -143 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/run_tests_unittest.py View 2 chunks +18 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741903002/40001
6 years, 1 month ago (2014-11-20 01:09:21 UTC) #2
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 03:48:22 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 03:48:55 UTC) #4
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7aa15ac741fbaf565ca0df43cf11e83e44b4b99e
Cr-Commit-Position: refs/heads/master@{#304964}

Powered by Google App Engine
This is Rietveld 408576698