Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 741883002: Do not use the 'original' profile for guest sessions (Closed)

Created:
6 years, 1 month ago by stevenjb
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not use the 'original' profile for guest sessions For guest sessions (profile->IsGuestSession), we do not use profile->GetOriginalProfile() for browser windows, we use the off the record profile instead. This was triggering an assert at the top of Browser::Browser(). BUG=434491 Committed: https://crrev.com/547026d2aff99e662d8dffe01b0ac1bfe81183d3 Cr-Commit-Position: refs/heads/master@{#305053}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/settings_window_manager.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
stevenjb
6 years, 1 month ago (2014-11-20 00:50:43 UTC) #2
stevenjb
6 years, 1 month ago (2014-11-20 00:59:48 UTC) #4
Mr4D (OOO till 08-26)
lgtm
6 years, 1 month ago (2014-11-20 04:19:37 UTC) #5
sky
LGTM
6 years, 1 month ago (2014-11-20 15:07:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741883002/1
6 years, 1 month ago (2014-11-20 17:49:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 18:59:46 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 19:00:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/547026d2aff99e662d8dffe01b0ac1bfe81183d3
Cr-Commit-Position: refs/heads/master@{#305053}

Powered by Google App Engine
This is Rietveld 408576698