Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 741873002: Avoid loading the chime when the hotword background page is opened. (Closed)

Created:
6 years, 1 month ago by Anand Mistry (off Chromium)
Modified:
6 years, 1 month ago
Reviewers:
rpetterson
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid loading the chime when the hotword background page is opened. Loading the chime causes the page to create an audio output stream. Setting preload=none on the audio tag prevents the chime from being loaded on startup, and instead causes it to be loaded on demand when the chime is played. BUG=432699, 397019 Committed: https://crrev.com/8b216d8eac67c5e5f8de4414e297a214c727b77d Cr-Commit-Position: refs/heads/master@{#304975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/hotword/state_manager.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Anand Mistry (off Chromium)
Dale: FYI.
6 years, 1 month ago (2014-11-19 23:16:14 UTC) #2
rpetterson
lgtm
6 years, 1 month ago (2014-11-20 01:18:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741873002/1
6 years, 1 month ago (2014-11-20 02:16:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 04:41:58 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 04:42:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b216d8eac67c5e5f8de4414e297a214c727b77d
Cr-Commit-Position: refs/heads/master@{#304975}

Powered by Google App Engine
This is Rietveld 408576698