The test attribute of a benchmark should refer to a page test class.

The test attribute of a benchmark should refer to a page test class.

Since we pass in a custom parameter, we must provide a custom
CreatePageTest class.

BUG=434981
Committed: https://crrev.com/d32138884f0497691a3969bdae5e2f27c22d50ef
Cr-Commit-Position: refs/heads/master@{#304986}

[ariblue, 2014-11-19 22:43:55]

ariblue@google.com changed reviewers:
+ achuith@chromium.org, ernstm@chromium.org

[achuithb, 2014-11-20 02:01:51]

On 2014/11/19 22:43:55, ariblue wrote:
> mailto:ariblue@google.com changed reviewers:
> + mailto:achuith@chromium.org, mailto:ernstm@chromium.org

lgtm, but somebody who understands this better should weigh in.

[tonyg, 2014-11-20 05:01:02]

tonyg@chromium.org changed reviewers:
+ tonyg@chromium.org

[tonyg, 2014-11-20 05:01:02]

The CQ bit was checked by tonyg@chromium.org

[tonyg, 2014-11-20 05:01:03]

lgtm

[commit-bot: I haz the power, 2014-11-20 05:02:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741853002/1

[commit-bot: I haz the power, 2014-11-20 07:05:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-20 07:06:14]

Patchset 1 (id:??) landed as
https://crrev.com/d32138884f0497691a3969bdae5e2f27c22d50ef
Cr-Commit-Position: refs/heads/master@{#304986}

[rnephew (Reviews Here), 2014-11-20 16:03:39]

Would this CL be causing this issue? If so, what steps should I take to fix
this.

Traceback (most recent call last):
  <module> at tools/perf/run_benchmark:18
    sys.exit(benchmark_runner.main())
  main at tools/telemetry/telemetry/benchmark_runner.py:336
    return command().Run(options)
  Run at tools/telemetry/telemetry/benchmark_runner.py:169
    return min(255, self._benchmark().Run(args))
  Run at tools/telemetry/telemetry/benchmark.py:87
    pt = self.CreatePageTest(finder_options)
  CreatePageTest at tools/telemetry/telemetry/benchmark.py:188
    if not issubclass(self.test, page_test.PageTest):
TypeError: issubclass() arg 1 must be a class


https://uberchromegw.corp.google.com/i/clank/builders/mako-sharded-official-p...

[ernstm, 2014-11-20 17:35:46]

On 2014/11/20 16:03:39, rnephew1 wrote:
> Would this CL be causing this issue? If so, what steps should I take to fix
> this.
> 
> Traceback (most recent call last):
>   <module> at tools/perf/run_benchmark:18
>     sys.exit(benchmark_runner.main())
>   main at tools/telemetry/telemetry/benchmark_runner.py:336
>     return command().Run(options)
>   Run at tools/telemetry/telemetry/benchmark_runner.py:169
>     return min(255, self._benchmark().Run(args))
>   Run at tools/telemetry/telemetry/benchmark.py:87
>     pt = self.CreatePageTest(finder_options)
>   CreatePageTest at tools/telemetry/telemetry/benchmark.py:188
>     if not issubclass(self.test, page_test.PageTest):
> TypeError: issubclass() arg 1 must be a class
> 
> 
>
https://uberchromegw.corp.google.com/i/clank/builders/mako-sharded-official-p...

Similar problem, but different benchmark. I'll make a patch to fix it.