Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 74183002: Introduce ui/wm/ directory. (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Introduce ui/wm/ directory. This starts by moving ui/shell into ui/wm/test/ directory and stabilish a wm.gyp to hold all the targets for wm. BUG=308710 TEST=None R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235481

Patch Set 1 : #

Total comments: 6

Patch Set 2 : changes requested by ben #

Patch Set 3 : #

Patch Set 4 : rm owners file so i can land this #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -186 lines) Patch
M apps/apps.gypi View 1 chunk +1 line, -1 line 0 comments Download
M apps/shell/app_shell_browser_main_parts.h View 2 chunks +5 lines, -5 lines 0 comments Download
M apps/shell/app_shell_browser_main_parts.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/browser/shell_views.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D ui/shell/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/shell/README.chromium View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/shell/minimal_shell.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ui/shell/minimal_shell.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D ui/shell/shell.gyp View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/views/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download
A ui/wm/README.chromium View 1 1 chunk +8 lines, -0 lines 0 comments Download
A + ui/wm/test/DEPS View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/wm/test/minimal_shell.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + ui/wm/test/minimal_shell.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/wm/wm.gyp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
Is this what you would like?
7 years, 1 month ago (2013-11-15 19:00:23 UTC) #1
Ben Goodger (Google)
LGTM with some changes: https://codereview.chromium.org/74183002/diff/20001/ui/wm/DEPS File ui/wm/DEPS (right): https://codereview.chromium.org/74183002/diff/20001/ui/wm/DEPS#newcode3 ui/wm/DEPS:3: "+ui/views", Can you move this ...
7 years, 1 month ago (2013-11-15 19:09:50 UTC) #2
tfarina
https://codereview.chromium.org/74183002/diff/20001/ui/wm/DEPS File ui/wm/DEPS (right): https://codereview.chromium.org/74183002/diff/20001/ui/wm/DEPS#newcode3 ui/wm/DEPS:3: "+ui/views", On 2013/11/15 19:09:50, Ben Goodger (Google) wrote: > ...
7 years, 1 month ago (2013-11-15 19:22:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/74183002/100001
7 years, 1 month ago (2013-11-15 19:42:28 UTC) #4
commit-bot: I haz the power
Failed to apply patch for ui/wm/OWNERS: While running patch -p1 --forward --force --no-backup-if-mismatch; A ui/wm/OWNERS ...
7 years, 1 month ago (2013-11-15 19:42:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/74183002/180001
7 years, 1 month ago (2013-11-15 22:35:49 UTC) #6
commit-bot: I haz the power
Failed to apply patch for ui/wm/OWNERS: While running patch -p1 --forward --force --no-backup-if-mismatch; A ui/wm/OWNERS ...
7 years, 1 month ago (2013-11-15 22:35:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/74183002/220001
7 years, 1 month ago (2013-11-15 23:00:46 UTC) #8
tfarina
Committed patchset #4 manually as r235481 (presubmit successful).
7 years, 1 month ago (2013-11-16 01:04:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/74183002/220001
7 years, 1 month ago (2013-11-16 01:33:19 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-16 01:33:26 UTC) #11
Message was sent while issue was closed. 
Failed to apply patch for ui/wm/test/DEPS:
File exist but was about to be overwriten
Patch:   NR  ui/shell/DEPS->ui/wm/test/DEPS
Index: ui/wm/test/DEPS
diff --git a/ui/shell/DEPS b/ui/wm/test/DEPS
similarity index 100%
rename from ui/shell/DEPS
rename to ui/wm/test/DEPS

Powered by Google App Engine
This is Rietveld 408576698