Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 741823003: Fix regression in chrome_proxy tests caused by switching to typ. (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix regression in chrome_proxy tests caused by switching to typ. When I switched telemetry to use typ in #304878, I missed that the chrome_proxy tests depended on the perf package as well. TBR=dtu@chromium.org, tonyg@chromium.org NOTREECHECKS=true NOTRY=true BUG=388256 Committed: https://crrev.com/0bb7170445d0eb1be8a2215b7446c66e95345cc8 Cr-Commit-Position: refs/heads/master@{#304901}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/chrome_proxy/run_tests View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741823003/1
6 years, 1 month ago (2014-11-19 22:16:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-19 22:17:45 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0bb7170445d0eb1be8a2215b7446c66e95345cc8 Cr-Commit-Position: refs/heads/master@{#304901}
6 years, 1 month ago (2014-11-19 22:18:25 UTC) #5
tommycli
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/738163003/ by tommycli@chromium.org. ...
6 years, 1 month ago (2014-11-19 23:54:00 UTC) #6
Dirk Pranke
6 years, 1 month ago (2014-11-20 00:33:55 UTC) #7
Message was sent while issue was closed.
On 2014/11/19 23:54:00, tommycli wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/738163003/ by mailto:tommycli@chromium.org.
> 
> The reason for reverting is: Sorry, this quick-fix didn't work:
>
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16872.

Argh :(  Thanks for reverting!

Powered by Google App Engine
This is Rietveld 408576698