Mojo: Raise the message size limit.

Mojo: Raise the message size limit.

The default message size limit 4MB is too small for Chrome IPC.

TEST=Layout Tests with a flag on
BUG=377980
R=viettrungluu@chromium.org, jam@chromium.org, nasko@chromium.org

Committed: https://crrev.com/872df152e57fe8ba6ebf668531147e482ca4f73f
Cr-Commit-Position: refs/heads/master@{#304938}

[Hajime Morrita, 2014-11-19 20:39:11]

Trung: PTAL?
John, Nasko: content/ OWNERS rubberstamp please?

[nasko, 2014-11-19 22:31:49]

https://codereview.chromium.org/741813002/diff/1/content/app/mojo/mojo_init.cc
File content/app/mojo/mojo_init.cc (right):

https://codereview.chromium.org/741813002/diff/1/content/app/mojo/mojo_init.c...
content/app/mojo/mojo_init.cc:19:
mojo::embedder::GetConfiguration()->max_message_num_bytes = 256*1024*1024;
I understand 4MB might be too small, but isn't 256MB a bit too much? Let's use
something that is a margin on top of the biggest message we've seen. I'd be more
comfortable with 32 or 64 to start with.

[Hajime Morrita, 2014-11-19 22:44:30]

Thanks for the revie Nasko. PTAL?

>
https://codereview.chromium.org/741813002/diff/1/content/app/mojo/mojo_init.c...
> content/app/mojo/mojo_init.cc:19:
> mojo::embedder::GetConfiguration()->max_message_num_bytes = 256*1024*1024;
> I understand 4MB might be too small, but isn't 256MB a bit too much? Let's use
> something that is a margin on top of the biggest message we've seen. I'd be
more
> comfortable with 32 or 64 to start with.
This makes sense.

I concerned that things like asm.js generates ridiculously big javascript and
it'd be bad if DevTools mysteriously fails with such ones.
But I agree that 256MB is a bit too much. It is now 64MB.

[nasko, 2014-11-19 22:45:48]

On 2014/11/19 22:44:30, morrita wrote:
> Thanks for the revie Nasko. PTAL?
> 
> >
>
https://codereview.chromium.org/741813002/diff/1/content/app/mojo/mojo_init.c...
> > content/app/mojo/mojo_init.cc:19:
> > mojo::embedder::GetConfiguration()->max_message_num_bytes = 256*1024*1024;
> > I understand 4MB might be too small, but isn't 256MB a bit too much? Let's
use
> > something that is a margin on top of the biggest message we've seen. I'd be
> more
> > comfortable with 32 or 64 to start with.
> This makes sense.
> 
> I concerned that things like asm.js generates ridiculously big javascript and
> it'd be bad if DevTools mysteriously fails with such ones.
> But I agree that 256MB is a bit too much. It is now 64MB.

This is behind a flag, right? Even if it breaks, it won't be in the default
build. LGTM

[viettrungluu, 2014-11-19 22:49:25]

64 MB seems better to me too. LGTM.

[Hajime Morrita, 2014-11-19 23:33:07]

The CQ bit was checked by morrita@chromium.org

[commit-bot: I haz the power, 2014-11-19 23:34:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/741813002/20001

[commit-bot: I haz the power, 2014-11-20 00:15:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-20 00:16:00]

Patchset 2 (id:??) landed as
https://crrev.com/872df152e57fe8ba6ebf668531147e482ca4f73f
Cr-Commit-Position: refs/heads/master@{#304938}