Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 741783003: Bindings: Support [ConstructorCallWith=ScriptState] (Closed)

Created:
6 years ago by jsbell
Modified:
6 years ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Project:
blink
Visibility:
Public.

Description

Bindings: Support [ConstructorCallWith=ScriptState] Sometimes an ExecutionContext just isn't enough. BUG=437151 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186624

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 1 chunk +1 line, -1 line 1 comment Download
M Source/bindings/scripts/v8_interface.py View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestInterfaceConstructor.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 7 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jsbell
haraken@, jl@ - please take a look? The specific use case is crrev.com/779133003 (which is ...
6 years ago (2014-12-05 20:09:45 UTC) #2
Jens Widell
LGTM
6 years ago (2014-12-05 20:34:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741783003/1
6 years ago (2014-12-05 21:08:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=186624
6 years ago (2014-12-05 21:14:10 UTC) #6
haraken
https://codereview.chromium.org/741783003/diff/1/Source/bindings/IDLExtendedAttributes.txt File Source/bindings/IDLExtendedAttributes.txt (right): https://codereview.chromium.org/741783003/diff/1/Source/bindings/IDLExtendedAttributes.txt#newcode45 Source/bindings/IDLExtendedAttributes.txt:45: ConstructorCallWith=ExecutionContext|ScriptState|Document Can we probably remove ExecutionContext and Document? We ...
6 years ago (2014-12-06 01:28:41 UTC) #7
haraken
6 years ago (2014-12-06 01:29:00 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698