Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Side by Side Diff: src/debug-debugger.js

Issue 741683002: Fix Unhandled ReferenceError in debug-debugger.js (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Default number of frames to include in the response to backtrace request. 5 // Default number of frames to include in the response to backtrace request.
6 var kDefaultBacktraceLength = 10; 6 var kDefaultBacktraceLength = 10;
7 7
8 var Debug = {}; 8 var Debug = {};
9 9
10 // Regular expression to skip "crud" at the beginning of a source line which is 10 // Regular expression to skip "crud" at the beginning of a source line which is
(...skipping 414 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 } 425 }
426 426
427 // Convert the line and column into an absolute position within the script. 427 // Convert the line and column into an absolute position within the script.
428 var position = Debug.findScriptSourcePosition(script, this.line(), column); 428 var position = Debug.findScriptSourcePosition(script, this.line(), column);
429 429
430 // If the position is not found in the script (the script might be shorter 430 // If the position is not found in the script (the script might be shorter
431 // than it used to be) just ignore it. 431 // than it used to be) just ignore it.
432 if (IS_NULL(position)) return; 432 if (IS_NULL(position)) return;
433 433
434 // Create a break point object and set the break point. 434 // Create a break point object and set the break point.
435 break_point = MakeBreakPoint(position, this); 435 var break_point = MakeBreakPoint(position, this);
436 break_point.setIgnoreCount(this.ignoreCount()); 436 break_point.setIgnoreCount(this.ignoreCount());
437 var actual_position = %SetScriptBreakPoint(script, position, 437 var actual_position = %SetScriptBreakPoint(script, position,
438 this.position_alignment_, 438 this.position_alignment_,
439 break_point); 439 break_point);
440 if (IS_UNDEFINED(actual_position)) { 440 if (IS_UNDEFINED(actual_position)) {
441 actual_position = position; 441 actual_position = position;
442 } 442 }
443 var actual_location = script.locationFromPosition(actual_position, true); 443 var actual_location = script.locationFromPosition(actual_position, true);
444 break_point.actual_location = { line: actual_location.line, 444 break_point.actual_location = { line: actual_location.line,
445 column: actual_location.column, 445 column: actual_location.column,
(...skipping 2134 matching lines...) Expand 10 before | Expand all | Expand 10 after
2580 2580
2581 default: 2581 default:
2582 json = null; 2582 json = null;
2583 } 2583 }
2584 return json; 2584 return json;
2585 } 2585 }
2586 2586
2587 Debug.TestApi = { 2587 Debug.TestApi = {
2588 CommandProcessorResolveValue: DebugCommandProcessor.resolveValue_ 2588 CommandProcessorResolveValue: DebugCommandProcessor.resolveValue_
2589 }; 2589 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698