Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 741683002: Fix Unhandled ReferenceError in debug-debugger.js (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
Yang, eseidel
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix Unhandled ReferenceError in debug-debugger.js This fixes following exception in Sky on attempt to set a breakpoint "Unhandled: Uncaught ReferenceError: break_point is not defined" I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode. BUG=None LOG=N R=yangguo@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2ad2237507c5b5f9047b8d94d2f4997327eae852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/debug-debugger.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
yurys
6 years, 1 month ago (2014-11-19 09:35:35 UTC) #2
Yang
On 2014/11/19 09:35:35, yurys wrote: lgtm. I think it generally makes sense to have both ...
6 years, 1 month ago (2014-11-19 09:43:44 UTC) #3
yurys
Committed patchset #1 (id:1) manually as 2ad2237507c5b5f9047b8d94d2f4997327eae852 (presubmit successful).
6 years, 1 month ago (2014-11-19 10:25:47 UTC) #4
yurys
6 years, 1 month ago (2014-11-19 12:15:41 UTC) #5
Message was sent while issue was closed.
On 2014/11/19 09:43:44, Yang wrote:
> On 2014/11/19 09:35:35, yurys wrote:
> 
> lgtm.
> 
> I think it generally makes sense to have both mirror-debugger.js and
> debug-debugger.js in strict mode by default.

Filed a bug on this:
https://code.google.com/p/v8/issues/detail?id=3708#makechanges

Powered by Google App Engine
This is Rietveld 408576698