Allow PRESUBMIT.py files to have old and new-style trybot specifications (as long as each file is c…

presubmit_support.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.7.0'
 
@@ skipping 1063 matching lines @@
   """
   presubmit_files = ListRelevantPresubmitFiles(changed_files, repository_root)
   if not presubmit_files and verbose:
     output_stream.write("Warning, no presubmit.py found.\n")
   results = []
   executer = GetTrySlavesExecuter()
   if default_presubmit:
     if verbose:
       output_stream.write("Running default presubmit script.\n")
     fake_path = os.path.join(repository_root, 'PRESUBMIT.py')
-    results += executer.ExecPresubmitScript(

[M-A Ruel, 2013/11/15 20:09:33]

I dislike using += on list anyway.

+    result = executer.ExecPresubmitScript(
         default_presubmit, fake_path, project, change)
+    if (all(isinstance(i, tuple) for i in result) or

[M-A Ruel, 2013/11/15 20:09:33]

Add a comment:
# Ensure it's either all old-style or new-style.

+        all(isinstance(i, basestring) for i in result)):
+      results += result
+    else:
+      raise ValueError('PRESUBMIT.py returned invalid trybot specification!')
   for filename in presubmit_files:

[M-A Ruel, 2013/11/15 20:09:33]

is this missing an else: ?

[ghost stip (do not use), 2013/11/22 01:24:16]

I don't think so? this is how the code was before

     filename = os.path.abspath(filename)
     if verbose:
       output_stream.write("Running %s\n" % filename)
     # Accept CRLF presubmit script.
     presubmit_script = gclient_utils.FileRead(filename, 'rU')
-    results += executer.ExecPresubmitScript(
+    result = executer.ExecPresubmitScript(
         presubmit_script, filename, project, change)
+    if (all(isinstance(i, tuple) for i in result) or
+        all(isinstance(i, basestring) for i in result)):
+      results += result

[M-A Ruel, 2013/11/15 20:09:33]

results.extend(result)

+    else:
+      raise ValueError('%s returned invalid trybot specification!' % filename)
 
-  if all(isinstance(i, tuple) for i in results):
-    # New-style [('bot', set(['tests']))] format.
-    slave_dict = {}
-    for result in results:
-      slave_dict.setdefault(result[0], set()).update(result[1])
-    slaves = list(slave_dict.iteritems())
-  elif all(isinstance(i, basestring) for i in results):
-    # Old-style ['bot'] format.
-    slaves = list(set(results))
-  else:
-    raise ValueError('PRESUBMIT.py returned invalid trybot specification!')
+
+  slave_dict = {}
+  old_style = filter(lambda x: isinstance(x, basestring), results)
+  new_style = filter(lambda x: isinstance(x, tuple), results)
+
+  for result in new_style:
+    slave_dict.setdefault(result[0], set()).update(result[1])
+  slaves = list(slave_dict.iteritems())
+
+  slaves += list(set(old_style))
 
   if slaves and verbose:
-    output_stream.write(', '.join(slaves))
+    output_stream.write(', '.join((str(x) for x in slaves)))
     output_stream.write('\n')
   return slaves
 
 
 class PresubmitExecuter(object):
   def __init__(self, change, committing, rietveld_obj, verbose):
     """
     Args:
       change: The Change object.
       committing: True if 'gcl commit' is running, False if 'gcl upload' is.
@@ skipping 327 matching lines @@
   except PresubmitFailure, e:
     print >> sys.stderr, e
     print >> sys.stderr, 'Maybe your depot_tools is out of date?'
     print >> sys.stderr, 'If all fails, contact maruel@'
     return 2
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(Main(None))