Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 741603002: Give release builds more time. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan, eseidel
CC:
mojo-reviews_chromium.org, eseidel
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Give release builds more time. Lets see if this removes the flake on the bots seen in sky tests. In local testing it looks like sky_server's CherryPy becomes overloaded and then the requests take a very long time to complete which makes the tests timeout. I increased the timeout locally and it made the tests start passing consistently when using high --repeat values. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/cf873181ba11ee78b72796419fc2c3d7ec4b5555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M sky/tools/webkitpy/layout_tests/port/base.py View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
esprehn
6 years, 1 month ago (2014-11-19 01:54:52 UTC) #1
ojan
lgtm We should just move back to apache. I don't see what cherrypy is buying ...
6 years, 1 month ago (2014-11-19 01:56:01 UTC) #2
abarth-chromium
On 2014/11/19 at 01:56:01, ojan wrote: > We should just move back to apache. I ...
6 years, 1 month ago (2014-11-19 02:03:27 UTC) #3
esprehn
Committed patchset #1 (id:1) manually as cf873181ba11ee78b72796419fc2c3d7ec4b5555 (presubmit successful).
6 years, 1 month ago (2014-11-19 02:03:39 UTC) #4
eseidel
I'm not at all tied to cherrypy. At the time it seemed simpler than writing ...
6 years, 1 month ago (2014-11-19 03:17:22 UTC) #6
ojan
On 2014/11/19 03:17:22, eseidel wrote: > I'm not at all tied to cherrypy. At the ...
6 years, 1 month ago (2014-11-19 06:32:45 UTC) #7
eseidel
6 years, 1 month ago (2014-11-19 07:36:46 UTC) #8
Message was sent while issue was closed.
Go for it! :)

Powered by Google App Engine
This is Rietveld 408576698