Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 741593003: Merge: Propagate the search request params from the browser to the Instant search base page to fix … (Closed)

Created:
6 years, 1 month ago by kmadhusu
Modified:
6 years, 1 month ago
Reviewers:
Ted C, jschuh, samarth, sky
CC:
chromium-reviews, davidben+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, David Black, jkarlin+watch_chromium.org, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

Merge: Propagate the search request params from the browser to the Instant search base page to fix the embedded search request logging issues. - Adds an attribute in EmbeddedSearch SearchBox API to pass the embedded search request params (such as omnibox query suggestion stats, original query, etc) to the Instant search base page at the query submission time. Server side bug: b/17555463 Server side CL: cl/76305813 BUG=421258 TEST=none TBR=samarth@chromium.org,tedchoc@chromium.org,jschuh@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/609493002 Cr-Commit-Position: refs/heads/master@{#304544} (cherry picked from commit 562c49c8edf16a40ef3f76fb6a57d7ac17331216) Committed: https://chromium.googlesource.com/chromium/src/+/5b56b600bad7dd00380004d9412a452c82a73500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+296 lines, -27 lines) Patch
M chrome/browser/android/tab_android.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_instant_controller.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/instant_controller.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 3 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_ipc_router.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_ipc_router_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/OWNERS View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/instant_types.h View 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/common/instant_types.cc View 2 chunks +60 lines, -0 lines 0 comments Download
A chrome/common/instant_types_unittest.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/searchbox_api.js View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox.cc View 3 chunks +8 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 3 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
kmadhusu
TBR'ing OWNERS.
6 years, 1 month ago (2014-11-19 01:41:02 UTC) #3
kmadhusu
6 years, 1 month ago (2014-11-19 01:45:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5b56b600bad7dd00380004d9412a452c82a73500 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698