Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 741523002: Add computation of saveLayer information to RecordingBench (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add computation of saveLayer information to RecordingBench In (Add flag to beginRecording to request saveLayer information - https://codereview.chromium.org/721883002/) I claimed the extra recording cost would be negligible. This CL attempts to put some numbers behind that. Committed: https://skia.googlesource.com/skia/+/80376531950b54c77d8084e6d81cd83c1592d92c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M bench/RecordingBench.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
robertphillips
6 years, 1 month ago (2014-11-18 19:10:12 UTC) #2
mtklein
LGTM Was curious and tested this locally. Very little perf impact on recording. CollectLayers was ...
6 years, 1 month ago (2014-11-18 19:21:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741523002/1
6 years, 1 month ago (2014-11-18 19:44:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/80376531950b54c77d8084e6d81cd83c1592d92c
6 years, 1 month ago (2014-11-18 19:53:07 UTC) #6
robertphillips
It looks like this only reliably moved the needle for the desk_carsvg.skp case. This skp ...
6 years, 1 month ago (2014-11-19 14:33:46 UTC) #7
mtklein
6 years, 1 month ago (2014-11-19 14:46:05 UTC) #8
Message was sent while issue was closed.
On 2014/11/19 14:33:46, robertphillips wrote:
> It looks like this only reliably moved the needle for the desk_carsvg.skp
case.
> This skp has the most layers (179) so that isn't all that surprising.

+1.  I'm not even sure I see a change to desk_carsvg

Powered by Google App Engine
This is Rietveld 408576698