Chromium Code Reviews
DescriptionRevert of Fire notifications when reboot is requested, not scheduled (patchset #5 id:80001 of https://codereview.chromium.org/727363002/)
Reason for revert:
This seems to have caused crashes on a couple of browser tests on the chromeos bots. See https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/34145/steps/browser_tests for details.
Original issue's description:
> Fire notifications when reboot is requested, not scheduled
>
> This CL fixes two bugs in the original implementation of the
> runtime.onRestartRequired() notification:
>
> 1) Fire a notification when a reboot is requested, not scheduled.
> 2) Fix race at start-up, ensuring that reboots scheduled before
> observer registration are not missed.
>
> BUG=433811
> TEST=Updated and extended unit and browser tests
>
> Committed: https://crrev.com/2bdfb49a86c46ac3a8a953a1e2f4e8e1bb41dc02
> Cr-Commit-Position: refs/heads/master@{#304624}
TBR=xiyuan@chromium.org,bartfab@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=433811
Committed: https://crrev.com/3e9ab1e27aafb0995e38a9401d1fd35c3adce967
Cr-Commit-Position: refs/heads/master@{#304638}
Patch Set 1 #
Created: 6 years, 1 month ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|