Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 741473002: Revert of Fire notifications when reboot is requested, not scheduled (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
Reviewers:
bartfab (slow), xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@managed_cros
Project:
chromium
Visibility:
Public.

Description

Revert of Fire notifications when reboot is requested, not scheduled (patchset #5 id:80001 of https://codereview.chromium.org/727363002/) Reason for revert: This seems to have caused crashes on a couple of browser tests on the chromeos bots. See https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/34145/steps/browser_tests for details. Original issue's description: > Fire notifications when reboot is requested, not scheduled > > This CL fixes two bugs in the original implementation of the > runtime.onRestartRequired() notification: > > 1) Fire a notification when a reboot is requested, not scheduled. > 2) Fix race at start-up, ensuring that reboots scheduled before > observer registration are not missed. > > BUG=433811 > TEST=Updated and extended unit and browser tests > > Committed: https://crrev.com/2bdfb49a86c46ac3a8a953a1e2f4e8e1bb41dc02 > Cr-Commit-Position: refs/heads/master@{#304624} TBR=xiyuan@chromium.org,bartfab@chromium.org NOTREECHECKS=true NOTRY=true BUG=433811 Committed: https://crrev.com/3e9ab1e27aafb0995e38a9401d1fd35c3adce967 Cr-Commit-Position: refs/heads/master@{#304638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -726 lines) Patch
M chrome/browser/chromeos/app_mode/app_session_lifetime.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service.cc View 4 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc View 5 chunks +14 lines, -78 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.h View 4 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager.cc View 7 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc View 87 chunks +304 lines, -610 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
Created Revert of Fire notifications when reboot is requested, not scheduled
6 years, 1 month ago (2014-11-18 17:58:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741473002/1
6 years, 1 month ago (2014-11-18 17:59:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-18 18:00:37 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e9ab1e27aafb0995e38a9401d1fd35c3adce967 Cr-Commit-Position: refs/heads/master@{#304638}
6 years, 1 month ago (2014-11-18 18:01:35 UTC) #4
bartfab (slow)
6 years, 1 month ago (2014-11-18 18:52:46 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698