Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: sky/viewer/content_handler_impl.cc

Issue 741453002: Make sure that Content Handled application can be connected multiple times. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/viewer/content_handler_impl.cc
diff --git a/sky/viewer/content_handler_impl.cc b/sky/viewer/content_handler_impl.cc
index 6a2d103f239b3f980efbcc1e6293aa5f160d0129..d0b40cd2277a18d039a66550cac9bd1ef033f08f 100644
--- a/sky/viewer/content_handler_impl.cc
+++ b/sky/viewer/content_handler_impl.cc
@@ -4,10 +4,74 @@
#include "sky/viewer/content_handler_impl.h"
+#include "base/bind.h"
+#include "mojo/public/cpp/application/connect.h"
+#include "mojo/services/public/interfaces/network/network_service.mojom.h"
#include "sky/viewer/document_view.h"
namespace sky {
+class SkyApplication : public mojo::Application {
+ public:
+ SkyApplication(scoped_refptr<base::MessageLoopProxy> compositor_thread,
+ mojo::ShellPtr shell,
+ mojo::URLResponsePtr response)
+ : compositor_thread_(compositor_thread),
+ url_(response->url),
+ shell_(shell.Pass()),
+ initial_response_(response.Pass()),
+ view_count_(0) {
+ shell_.set_client(this);
+ mojo::ServiceProviderPtr service_provider;
+ shell_->ConnectToApplication("mojo:network_service",
+ mojo::GetProxy(&service_provider));
+ mojo::ConnectToService(service_provider.get(), &network_service_);
+ }
+
+ void Initialize(mojo::Array<mojo::String> args) override {}
+
+ void AcceptConnection(const mojo::String& requestor_url,
+ mojo::ServiceProviderPtr provider) override {
+ ++view_count_;
+ if (initial_response_) {
+ OnResponseReceived(nullptr, provider.Pass(), initial_response_.Pass());
+ } else {
+ mojo::URLLoaderPtr* loader = new mojo::URLLoaderPtr;
+ network_service_->CreateURLLoader(mojo::GetProxy(loader));
+ mojo::URLRequestPtr request(mojo::URLRequest::New());
+ request->url = url_;
+ request->auto_follow_redirects = true;
+ (*loader)->Start(request.Pass(),
+ base::Bind(&SkyApplication::OnResponseReceived,
+ base::Unretained(this), base::Owned(loader),
+ base::Passed(&provider)));
+ }
+ }
+
+ private:
+ void OnViewDestroyed() {
+ --view_count_;
+ if (view_count_ == 0) {
+ delete this;
+ }
+ }
+
+ void OnResponseReceived(mojo::URLLoaderPtr* loader,
+ mojo::ServiceProviderPtr provider,
+ mojo::URLResponsePtr response) {
+ new DocumentView(
+ base::Bind(&SkyApplication::OnViewDestroyed, base::Unretained(this)),
+ provider.Pass(), response.Pass(), shell_.get(), compositor_thread_);
+ }
+
+ scoped_refptr<base::MessageLoopProxy> compositor_thread_;
+ mojo::String url_;
+ mojo::ShellPtr shell_;
+ mojo::NetworkServicePtr network_service_;
+ mojo::URLResponsePtr initial_response_;
+ uint32_t view_count_;
+};
+
ContentHandlerImpl::ContentHandlerImpl(
scoped_refptr<base::MessageLoopProxy> compositor_thread)
: compositor_thread_(compositor_thread) {
@@ -18,7 +82,7 @@ ContentHandlerImpl::~ContentHandlerImpl() {
void ContentHandlerImpl::StartApplication(mojo::ShellPtr shell,
mojo::URLResponsePtr response) {
- new DocumentView(response.Pass(), shell.Pass(), compositor_thread_);
+ new SkyApplication(compositor_thread_, shell.Pass(), response.Pass());
}
} // namespace sky

Powered by Google App Engine
This is Rietveld 408576698