Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: mojo/shell/network_application_loader.cc

Issue 741453002: Make sure that Content Handled application can be connected multiple times. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/shell/network_application_loader.cc
diff --git a/mojo/shell/network_application_loader.cc b/mojo/shell/network_application_loader.cc
index dbe70b767c00fd1fef0950fe1d5852a517da7fc9..e3b182e519b83d3f02cbfdde5286616228e21e82 100644
--- a/mojo/shell/network_application_loader.cc
+++ b/mojo/shell/network_application_loader.cc
@@ -31,11 +31,9 @@ NetworkApplicationLoader::~NetworkApplicationLoader() {
void NetworkApplicationLoader::Load(ApplicationManager* manager,
const GURL& url,
- scoped_refptr<LoadCallbacks> callbacks) {
- ScopedMessagePipeHandle shell_handle = callbacks->RegisterApplication();
- if (!shell_handle.is_valid())
- return;
-
+ ScopedMessagePipeHandle shell_handle,
+ LoadCallback callbacks) {
+ DCHECK(shell_handle.is_valid());
uintptr_t key = reinterpret_cast<uintptr_t>(manager);
if (apps_.find(key) == apps_.end()) {
scoped_ptr<ApplicationImpl> app(

Powered by Google App Engine
This is Rietveld 408576698