mojo/application_manager/background_shell_application_loader.h - Issue 741453002: Make sure that Content Handled application can be connected multiple times.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application_manager/background_shell_application_loader.h

Issue 741453002: Make sure that Content Handled application can be connected multiple times. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/application_manager/application_manager.cc ('K') | « mojo/application_manager/application_manager_unittest.cc ('k') | mojo/application_manager/background_shell_application_loader.cc » ('j') | mojo/shell/dynamic_application_loader.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/application_manager/background_shell_application_loader.h

diff --git a/mojo/application_manager/background_shell_application_loader.h b/mojo/application_manager/background_shell_application_loader.h

index 399df434ea648059687cb9704365499433155689..0c8e806f6f40b7444c65f7fde282a1ae16cf3820 100644

--- a/mojo/application_manager/background_shell_application_loader.h

+++ b/mojo/application_manager/background_shell_application_loader.h

@@ -29,6 +29,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader

// ApplicationLoader overrides:

void Load(ApplicationManager* manager,

const GURL& url,

+ ScopedMessagePipeHandle shell_handle,

scoped_refptr<LoadCallbacks> callbacks) override;

void OnApplicationError(ApplicationManager* manager,

const GURL& url) override;

@@ -45,7 +46,7 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader

// isn't thread safe).

void LoadOnBackgroundThread(ApplicationManager* manager,

const GURL& url,

- ScopedMessagePipeHandle* shell_handle);

+ ScopedMessagePipeHandle shell_handle);

void OnApplicationErrorOnBackgroundThread(ApplicationManager* manager,

const GURL& url);

bool quit_on_shutdown_;

@@ -66,9 +67,6 @@ class MOJO_APPLICATION_MANAGER_EXPORT BackgroundShellApplicationLoader

scoped_ptr<base::DelegateSimpleThread> thread_;

- // Lives on |thread_|. Trivial interface that calls through to |loader_|.

- BackgroundLoader* background_loader_;

DISALLOW_COPY_AND_ASSIGN(BackgroundShellApplicationLoader);

};