Issue 741443002: Revert of SkVarAlloc::approxBytesAllocated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 741443002: Revert of SkVarAlloc::approxBytesAllocated (Closed)

Created:
6 years, 1 month ago by mtklein

Modified:
6 years, 1 month ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of SkVarAlloc::approxBytesAllocated (patchset #5 id:80001 of https://codereview.chromium.org/730193003/) Reason for revert: Android needs dlmalloc_usable_size(). Original issue's description: > SkVarAlloc::approxBytesAllocated() > > This is what I was getting at on the other CL. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/f27f1bcce50c8f95aea8469684a70b70c9baee09 > > CQ_EXTRA_TRYBOTS=Test-Android-Nexus5-Adreno330-Arm7-Release-Trybot TBR=reed@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/52b7822fa67e1d587035165258959f9600f8572d

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -38 lines)			Patch
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkVarAlloc.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/core/SkVarAlloc.cpp	View	2 chunks	+3 lines, -24 lines	0 comments	Download
D	tests/VarAllocTest.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741443002/1

6 years, 1 month ago (2014-11-18 16:15:14 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-18 16:15:27 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/52b7822fa67e1d587035165258959f9600f8572d