Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 741433003: Add an image filter row to GM:lcdtextprops (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add an image filter row to GM:lcdtextprops We should be disabling LCD text when rendering image filters, but currently don't. Add a GM to capture this behavior. R=reed@google.com Committed: https://skia.googlesource.com/skia/+/65d79cefe2452288228ec53fe0b7153934b0f9a3

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Patch Set 3 : update onISize() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -10 lines) Patch
M gm/lcdtext.cpp View 1 2 3 chunks +45 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
f(malita)
6 years, 1 month ago (2014-11-19 14:25:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741433003/1
6 years, 1 month ago (2014-11-19 15:23:23 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-19 15:23:23 UTC) #4
reed1
lgtm w/ request for refactoring. https://codereview.chromium.org/741433003/diff/1/gm/lcdtext.cpp File gm/lcdtext.cpp (right): https://codereview.chromium.org/741433003/diff/1/gm/lcdtext.cpp#newcode173 gm/lcdtext.cpp:173: SkPictureRecorder recorder; maybe we ...
6 years, 1 month ago (2014-11-19 16:39:24 UTC) #5
f(malita)
https://codereview.chromium.org/741433003/diff/1/gm/lcdtext.cpp File gm/lcdtext.cpp (right): https://codereview.chromium.org/741433003/diff/1/gm/lcdtext.cpp#newcode173 gm/lcdtext.cpp:173: SkPictureRecorder recorder; On 2014/11/19 16:39:24, reed1 wrote: > maybe ...
6 years, 1 month ago (2014-11-19 17:08:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741433003/20001
6 years, 1 month ago (2014-11-19 17:09:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741433003/40001
6 years, 1 month ago (2014-11-19 17:14:52 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 17:23:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/65d79cefe2452288228ec53fe0b7153934b0f9a3

Powered by Google App Engine
This is Rietveld 408576698