Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp - Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/custom/V8FormDataCustom.cpp ('K') | « Source/bindings/v8/custom/V8FormDataCustom.cpp ('k') | Source/bindings/v8/custom/V8InspectorFrontendHostCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

index a7ad64edc1760af269c8930bf6e3f32ef116cef9..8c011d0d92261915239309026d22b4208a8fedb3 100644

--- a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

@@ -45,7 +45,7 @@ using namespace HTMLNames;

void V8HTMLFrameElement::locationAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)

{

HTMLFrameElement* frame = V8HTMLFrameElement::toNative(info.Holder());

- String locationValue = toWebCoreStringWithNullCheck(value);

+ V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, locationValue, value);

ExceptionState exceptionState(info.Holder(), info.GetIsolate());

if (protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(locationValue)) && !BindingSecurity::shouldAllowAccessToFrame(frame->contentFrame(), exceptionState)) {