Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 v8SetReturnValueString(info, result, info.GetIsolate()); 223 v8SetReturnValueString(info, result, info.GetIsolate());
224 } 224 }
225 225
226 void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name , v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info) 226 void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::String> name , v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info)
227 { 227 {
228 CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder()); 228 CSSStyleDeclaration* imp = V8CSSStyleDeclaration::toNative(info.Holder());
229 CSSPropertyInfo* propInfo = cssPropertyInfo(name); 229 CSSPropertyInfo* propInfo = cssPropertyInfo(name);
230 if (!propInfo) 230 if (!propInfo)
231 return; 231 return;
232 232
233 String propertyValue = toWebCoreStringWithNullCheck(value); 233 V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, proper tyValue, value);
234
235 ExceptionState exceptionState(info.Holder(), info.GetIsolate()); 234 ExceptionState exceptionState(info.Holder(), info.GetIsolate());
236 imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), prope rtyValue, false, exceptionState); 235 imp->setPropertyInternal(static_cast<CSSPropertyID>(propInfo->propID), prope rtyValue, false, exceptionState);
237 236
238 if (exceptionState.throwIfNeeded()) 237 if (exceptionState.throwIfNeeded())
239 return; 238 return;
240 239
241 v8SetReturnValue(info, value); 240 v8SetReturnValue(info, value);
242 } 241 }
243 242
244 } // namespace WebCore 243 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698