LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html - Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter.html

Issue 74133005: Remove several uses of toWebCoreStringWithNullCheck(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/dom/CSSStyleDeclaration/css-style-declaration-named-setter-expected.txt » ('j') | Source/bindings/v8/custom/V8FormDataCustom.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../../resources/js-test.js"></script>	3 <script src="../../../resources/js-test.js"></script>

4 </head>	4 </head>

5 <body style="margin: 0px">	5 <body style="margin: 0px">

6 <script>	6 <script>

7	7

8 shouldBeEqualToString("document.body.style.margin", "0px");	8 shouldBeEqualToString("document.body.style.margin", "0px");

9 shouldBe("document.body.style.margin = 1", "1");	9 shouldBe("document.body.style.margin = 1", "1");

10 shouldBeEqualToString("document.body.style.margin", "1px");	10 shouldBeEqualToString("document.body.style.margin", "1px");

11	11

12 shouldBe("document.body.style.__proto__.margin = 777", "777");	12 shouldBe("document.body.style.__proto__.margin = 777", "777");

13 shouldBe("document.body.style.__proto__.margin", "777");	13 shouldBe("document.body.style.__proto__.margin", "777");

14	14

15 shouldBeEqualToString("document.body.style.margin", "1px");	15 shouldBeEqualToString("document.body.style.margin", "1px");

16 shouldBe("document.body.style.margin = 2", "2");	16 shouldBe("document.body.style.margin = 2", "2");

17 shouldBeEqualToString("document.body.style.margin", "2px");	17 shouldBeEqualToString("document.body.style.margin", "2px");

18	18

	19 var badString = { toString: function() { throw "Exception in toString()"; } };

	20 shouldThrow("document.body.style.margin = badString", "'Exception in toString()' ");

	21 shouldBeEqualToString("document.body.style.margin", "2px"); // Should not reset the previous value.

	22

19 </script>	23 </script>

20 </body>	24 </body>

21 </html>	25 </html>

OLD	NEW