Source/core/rendering/svg/SVGRenderSupport.h - Issue 741123002: Get rid of computeFloatRectForPaintInvalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGRenderSupport.h

Issue 741123002: Get rid of computeFloatRectForPaintInvalidation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/svg/RenderSVGRoot.cpp ('K') | « Source/core/rendering/svg/RenderSVGRoot.cpp ('k') | Source/core/rendering/svg/SVGRenderSupport.cpp » ('j') | Source/core/rendering/svg/SVGRenderSupport.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/SVGRenderSupport.h

diff --git a/Source/core/rendering/svg/SVGRenderSupport.h b/Source/core/rendering/svg/SVGRenderSupport.h

index 60fd7ea2fe432d604dbaa5d32320e61d82652007..83a85fbe9894b56971eb77ec5031ebca8c74d75f 100644

--- a/Source/core/rendering/svg/SVGRenderSupport.h

+++ b/Source/core/rendering/svg/SVGRenderSupport.h

@@ -75,7 +75,7 @@ public:

// Important functions used by nearly all SVG renderers centralizing coordinate transformations / paint invalidation rect calculations

static LayoutRect clippedOverflowRectForPaintInvalidation(const RenderObject*, const RenderLayerModelObject* paintInvalidationContainer, const PaintInvalidationState*);

- static void computeFloatRectForPaintInvalidation(const RenderObject*, const RenderLayerModelObject* paintInvalidationContainer, FloatRect&, const PaintInvalidationState*);

+ static const RenderSVGRoot* mapRectToSVGRootForPaintInvalidation(const RenderObject*, const FloatRect& localPaintInvalidationRect, LayoutRect&);

pdr. 2014/11/21 08:32:05 Can this return a reference?

fs 2014/11/21 11:23:15 Sure can.

static void mapLocalToContainer(const RenderObject*, const RenderLayerModelObject* paintInvalidationContainer, TransformState&, bool* wasFixed = 0, const PaintInvalidationState* = 0);

static const RenderObject* pushMappingToContainer(const RenderObject*, const RenderLayerModelObject* ancestorToStopAt, RenderGeometryMap&);