Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 741093002: SkRecord: Pack SkRegion::Op and AA bit together. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

SkRecord: Pack SkRegion::Op and AA bit together. Saves 4 bytes per clip op. BUG=skia: Committed: https://skia.googlesource.com/skia/+/cdeeb095a629b0db9f0ddff09516f2b78255c047

Patch Set 1 #

Patch Set 2 : try int #

Patch Set 3 : Duh, int : 1 can only hold 0,-1. #

Patch Set 4 : Weird, what's your problem MSVC? #

Patch Set 5 : MSVC, your whims are seemingly arbitrary. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/core/SkRecordDraw.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M src/core/SkRecords.h View 1 2 3 4 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
mtklein
6 years, 1 month ago (2014-11-20 16:06:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741093002/1
6 years, 1 month ago (2014-11-20 16:07:18 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-20 16:07:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1096)
6 years, 1 month ago (2014-11-20 16:15:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741093002/20001
6 years, 1 month ago (2014-11-20 16:23:55 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-20 16:23:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1098)
6 years, 1 month ago (2014-11-20 16:27:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741093002/40001
6 years, 1 month ago (2014-11-20 16:41:55 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-20 16:41:56 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1100)
6 years, 1 month ago (2014-11-20 16:45:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741093002/60001
6 years, 1 month ago (2014-11-20 16:48:55 UTC) #19
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-20 16:48:56 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1103)
6 years, 1 month ago (2014-11-20 16:52:08 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/741093002/80001
6 years, 1 month ago (2014-11-20 16:56:55 UTC) #24
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-11-20 16:56:57 UTC) #25
mtklein
MSVC has finally yielded to my will. Should be a good time to take a ...
6 years, 1 month ago (2014-11-20 17:06:48 UTC) #26
tomhudson
lgtm
6 years, 1 month ago (2014-11-20 17:12:53 UTC) #27
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:14:34 UTC) #28
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/cdeeb095a629b0db9f0ddff09516f2b78255c047

Powered by Google App Engine
This is Rietveld 408576698