Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 74103002: ninja: When the installed Xcode is Xcode 5 or later, use ['x86_64'] as the default value of ARCHS (Closed)

Created:
7 years, 1 month ago by Mark Mentovai
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja: When the installed Xcode is Xcode 5 or later, use ['x86_64'] as the default value of ARCHS instead of ['i386']. This mimics the behavior of the installed Xcode. BUG=gyp:381 R=thakis@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1790

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -15 lines) Patch
M pylib/gyp/xcode_emulation.py View 1 6 chunks +24 lines, -11 lines 0 comments Download
M test/mac/gyptest-archs.py View 1 2 1 chunk +18 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
7 years, 1 month ago (2013-11-15 18:48:59 UTC) #1
Nico
lgtm (Can't think of a good way to test this.)
7 years, 1 month ago (2013-11-17 05:19:16 UTC) #2
Mark Mentovai
7 years, 1 month ago (2013-11-18 14:59:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r1790 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698