Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: printing/printing_context.h

Issue 740983002: Implement window.print() on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/printing_context.h
diff --git a/printing/printing_context.h b/printing/printing_context.h
index 0cc4731a19e98169d44b25ad235810dcd0d34818..d9fda4a62bc5775ed5cbac339dd34d6f05f91e2c 100644
--- a/printing/printing_context.h
+++ b/printing/printing_context.h
@@ -38,11 +38,12 @@ class PRINTING_EXPORT PrintingContext {
virtual std::string GetAppLocale() = 0;
};
- // Tri-state result for user behavior-dependent functions.
+ // Result for user behavior-dependent functions.
enum Result {
OK,
CANCEL,
FAILED,
+ SYSTEM_DIALOG_DONE,
Vitaly Buka (NO REVIEWS) 2014/12/12 08:37:17 don't see where you check SYSTEM_DIALOG_DONE pleas
dgn 2014/12/12 16:49:44 I'm just using a value that is not OK to avoid pro
};
virtual ~PrintingContext();
@@ -51,6 +52,10 @@ class PRINTING_EXPORT PrintingContext {
// print settings are available.
typedef base::Callback<void(Result)> PrintSettingsCallback;
+ // Called when a printing process initiated by a script finishes.
+ // It's required to synchronize window.print() calls on Android
+ virtual void RequestSystemDialog(const PrintSettingsCallback& cb);
Vitaly Buka (NO REVIEWS) 2014/12/12 08:37:17 please remove RequestSystemDialog and add bool int
+
// Asks the user what printer and format should be used to print. Updates the
// context with the select device settings. The result of the call is returned
// in the callback. This is necessary for Linux, which only has an

Powered by Google App Engine
This is Rietveld 408576698