chrome/browser/android/tab_android.cc - Issue 740983002: Implement window.print() on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 740983002: Implement window.print() on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adressed mounir's comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index b377cecf7c02b44cfef85241ac4d222e2dbb30f6..ca0fbf9512e02caff22c3befe9e1de180e5a7d9f 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -643,6 +643,12 @@ bool TabAndroid::Print(JNIEnv* env, jobject obj) {

return true;

}

+void TabAndroid::SetPendingPrint() {

+ LOG(INFO) << "DGN TabAndroid::SetPendingPrint";

+ JNIEnv* env = base::android::AttachCurrentThread();

+ Java_Tab_setPendingPrint(env, weak_java_tab_.get(env).obj());

ScopedJavaLocalRef<jobject> TabAndroid::GetDefaultFavicon(JNIEnv* env,

jobject obj) {

ScopedJavaLocalRef<jobject> bitmap;