Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5567)

Unified Diff: chrome/browser/android/tab_android.cc

Issue 740983002: Implement window.print() on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/tab_android.cc
diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc
index b5dec4f5d4bd8de5102abc67c943587b01f7a5e9..4e3bff59640d7fe7af7f7a3e8095fe57746d5c2b 100644
--- a/chrome/browser/android/tab_android.cc
+++ b/chrome/browser/android/tab_android.cc
@@ -632,19 +632,29 @@ void TabAndroid::SetActiveNavigationEntryTitleForUrl(JNIEnv* env,
}
bool TabAndroid::Print(JNIEnv* env, jobject obj) {
- if (!web_contents())
+ LOG(INFO) << "DGN TabAndroid::Print";
+ if (!web_contents()) {
+ LOG(INFO) << "DGN TabAndroid::Print - No webcontents";
return false;
+ }
printing::PrintViewManagerBasic::CreateForWebContents(web_contents());
printing::PrintViewManagerBasic* print_view_manager =
printing::PrintViewManagerBasic::FromWebContents(web_contents());
- if (print_view_manager == NULL)
+ if (print_view_manager == NULL) {
+ LOG(INFO) << "DGN TabAndroid::Print - No print_view_manager";
return false;
+ }
print_view_manager->PrintNow();
return true;
}
+void TabAndroid::ShowPrintDialog() {
+ JNIEnv* env = base::android::AttachCurrentThread();
+ Java_Tab_showPrintDialog(env, weak_java_tab_.get(env).obj());
+}
+
ScopedJavaLocalRef<jobject> TabAndroid::GetDefaultFavicon(JNIEnv* env,
jobject obj) {
ScopedJavaLocalRef<jobject> bitmap;

Powered by Google App Engine
This is Rietveld 408576698