sky/compositor/layer_client.cc - Issue 740923002: Add a simple compositor for Sky

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/compositor/layer_client.cc

Issue 740923002: Add a simple compositor for Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: git cl format Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "own_ptr_to_gc_managed_class.h"	5 #include "sky/compositor/layer_client.h"

6	6

7 namespace blink {	7 namespace sky {

8	8

9 void HeapObject::trace(Visitor* visitor) { }	9 LayerClient::~LayerClient() {
	ojan 2014/11/20 21:25:46 Does chromium style require we have a cc file here Does chromium style require we have a cc file here? Seems kinda silly to not just put the empty destructor in the header? eseidel 2014/11/20 21:35:09 Destructors are deceptive. All the member destruc Show quoted text On 2014/11/20 21:25:46, ojan wrote: > Does chromium style require we have a cc file here? Seems kinda silly to not > just put the empty destructor in the header? Destructors are deceptive. All the member destructors are called from this. In this object's case that's like 5 destructors worth. That ends up compiling into every .o file and then needing to be stripped by the linker. Much better to be in a separate file imo. abarth-chromium 2014/11/20 22:07:20 It also makes sure layer_client.h compiles without Show quoted text On 2014/11/20 at 21:35:09, eseidel wrote: > Destructors are deceptive. All the member destructors are called from this. In this object's case that's like 5 destructors worth. That ends up compiling into every .o file and then needing to be stripped by the linker. Much better to be in a separate file imo. It also makes sure layer_client.h compiles without any other headers included first. I think the style guide allows us to include {} in the header though.
	10 }

10	11

11 }	12 } // namespace sky

OLD	NEW

« sky/compositor/layer.h ('K') | « sky/compositor/layer_client.h ('k') | sky/compositor/layer_host.h » ('j') | sky/compositor/resource_manager.cc » ('J')