Issue 740863003: gn: delete some dead code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 740863003: gn: delete some dead code (Closed)

Created:
6 years, 1 month ago by scottmg

Modified:
6 years, 1 month ago

Reviewers:
tfarina, brettw

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-penalty-binop

Project:
chromium

Visibility:
Public.

gn: delete some dead code Unused. R=brettw@chromium.org Committed: https://crrev.com/4d3559a728b974d256073f9f3e3b06e185c4a00f Cr-Commit-Position: refs/heads/master@{#305060}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -46 lines)			Patch
	M	tools/gn/operators.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download
	M	tools/gn/operators.cc	View		1 chunk	+0 lines, -36 lines	0 comments	Download

Total messages: 8 (2 generated)

tfarina

lgtm Confirmed. I did `git grep` for those functions in tools/gn.

6 years, 1 month ago (2014-11-20 16:40:09 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740863003/1

6 years, 1 month ago (2014-11-20 18:48:10 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-20 19:35:32 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4d3559a728b974d256073f9f3e3b06e185c4a00f
Cr-Commit-Position: refs/heads/master@{#305060}