DescriptionRevert of ChromeBrowserProvider shouldn't own the FaviconService (patchset #1 id:1 of https://codereview.chromium.org/731873003/)
Reason for revert:
Broke the branch build. https://uberchromegw.corp.google.com/i/chrome.mobile/builders/arm%20stable/builds/7097
Original issue's description:
> ChromeBrowserProvider shouldn't own the FaviconService
>
> As FaviconService is KeyedService and will be deleted along with profile.
>
> BUG=411435
> TBR=Tedchoc
>
> Review URL: https://codereview.chromium.org/739713002
>
> Cr-Commit-Position: refs/heads/master@{#304690}
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8c5b8c707daa9c026540a63f6f1e1c5981f5909c
TBR=michaelbai@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=411435
Committed: https://crrev.com/fa4053cc550e8989991006ea59a171bc3dd8e6e3
Cr-Commit-Position: refs/heads/master@{#304979}
Patch Set 1 #
Created: 6 years, 1 month ago
(Patch set is too large to download)
Messages
Total messages: 6 (1 generated)
|