Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 74083004: Swap IDR_OMNIBOX_FILLING.* so that the omnibox is not semi transparent on CrOS (Closed)

Created:
7 years, 1 month ago by pkotwicz
Modified:
7 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Swap IDR_OMNIBOX_FILLING.* so that the omnibox is not semi transparent on CrOS BUG=309569 TEST=Manual, see bug R=oshima Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M chrome/app/theme/default_100_percent/common/omnibox_filling_bottom.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_bottom_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_bottom_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_center.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_right.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_top.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_top_left.png View Binary file 0 comments Download
M chrome/app/theme/default_100_percent/common/omnibox_filling_top_right.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_bottom.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_bottom_left.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_bottom_right.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_center.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_left.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_right.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_top.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_top_left.png View Binary file 0 comments Download
M chrome/app/theme/default_200_percent/common/omnibox_filling_top_right.png View Binary file 0 comments Download

Messages

Total messages: 7 (0 generated)
pkotwicz
oshima, PTAL
7 years, 1 month ago (2013-11-15 23:11:23 UTC) #1
Peter Kasting
I'm pretty sure you did, but just to be clear, you ran these through tools/resources/optimize-png-files.sh ...
7 years, 1 month ago (2013-11-15 23:15:51 UTC) #2
pkotwicz
I did optimize the PNG files :)
7 years, 1 month ago (2013-11-15 23:29:21 UTC) #3
oshima
lgtm
7 years, 1 month ago (2013-11-15 23:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/74083004/1
7 years, 1 month ago (2013-11-15 23:50:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/74083004/1
7 years, 1 month ago (2013-11-16 01:31:06 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:59:42 UTC) #7
Message was sent while issue was closed.
Change committed as 235718

Powered by Google App Engine
This is Rietveld 408576698