Allow controls other than windows to send alert accessibility events.

Allow controls other than windows to send alert accessibility events.

This makes battery alerts and network state change notifications emit
spoken (and braille) feedback again and fixes a crash on ash debug
builds when accessibility is enabled.

BUG=310766
R=dmazzoni@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235764

[dmazzoni, 2013-11-15 19:33:10]

lgtm

[sky, 2013-11-16 00:28:46]

https://codereview.chromium.org/74083003/diff/170001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc
(right):

https://codereview.chromium.org/74083003/diff/170001/chrome/browser/ui/views/...
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc:404:
window->Activate();
If you're relying on activation then this needs to be in interactive ui tests.

[dmazzoni, 2013-11-16 00:35:14]

https://codereview.chromium.org/74083003/diff/170001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc
(right):

https://codereview.chromium.org/74083003/diff/170001/chrome/browser/ui/views/...
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc:404:
window->Activate();
On 2013/11/16 00:28:46, sky wrote:
> If you're relying on activation then this needs to be in interactive ui tests.

I think this is okay. This test is really a unit test and doesn't depend on the
window being active. I added the call to Activate above because it was done in
other views unittests.

If it seems to work without the call to Activate, should we get rid of it? In
general should we get rid of Activate in other views unittests?

[plundblad, 2013-11-16 00:48:25]

PTAL

dmazzoni@chromium.org writes:
> 
>
https://codereview.chromium.org/74083003/diff/170001/chrome/browser/ui/views/...
> File
>
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/74083003/diff/170001/chrome/browser/ui/views/...
>
chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc:404:
> window->Activate();
> On 2013/11/16 00:28:46, sky wrote:
> > If you're relying on activation then this needs to be in interactive
> ui tests.
> 
> I think this is okay. This test is really a unit test and doesn't depend
> on the window being active. I added the call to Activate above because
> it was done in other views unittests.
> 
> If it seems to work without the call to Activate, should we get rid of
> it? In general should we get rid of Activate in other views unittests?

I went ahead and dropped the Activate calls from both tests in this file that
had it and they still pass.

//Peter


> https://codereview.chromium.org/74083003/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2013-11-18 14:25:17]

LGTM - if activation isn't required then definitely remove it. Remember that
tests run in parallel, so that if you are relying on activation it is entirely
possible to get random behavior when multiple tests try to change activation.

[commit-bot: I haz the power, 2013-11-18 15:43:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/plundblad@chromium.org/74083003/420001

[commit-bot: I haz the power, 2013-11-18 18:21:07]

Change committed as 235764