content/browser/manifest/manifest_manager_host.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/manifest/manifest_manager_host.cc

diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc

index 50b3ecade66ca6ab3dd258dc8785787920962c71..d32a8c349cba212852e94b04903216ad95696d2a 100644

--- a/content/browser/manifest/manifest_manager_host.cc

+++ b/content/browser/manifest/manifest_manager_host.cc

@@ -19,7 +19,8 @@ void KillRenderer(RenderFrameHost* render_frame_host) {

render_frame_host->GetProcess()->GetHandle();

if (process_handle == base::kNullProcessHandle)

return;

- base::KillProcess(process_handle, RESULT_CODE_KILLED_BAD_MESSAGE, false);

+ render_frame_host->GetProcess()->Shutdown(RESULT_CODE_KILLED_BAD_MESSAGE,

+ false);

}

} // anonymous namespace

« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »