Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/ui/views/hung_renderer_view.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/hung_renderer_view.h ('k') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/hung_renderer_view.cc
diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc
index bbbc9f4ecb589e8f01260e1b7333f3912cc9b443..aa099295b12e95ab6ad123414b3b773cd826c106 100644
--- a/chrome/browser/ui/views/hung_renderer_view.cc
+++ b/chrome/browser/ui/views/hung_renderer_view.cc
@@ -196,12 +196,12 @@ bool HungRendererDialogView::IsFrameActive(WebContents* contents) {
// static
void HungRendererDialogView::KillRendererProcess(
- base::ProcessHandle process_handle) {
+ content::RenderProcessHost* rph) {
#if defined(OS_WIN)
// Try to generate a crash report for the hung process.
- CrashDumpAndTerminateHungChildProcess(process_handle);
+ CrashDumpAndTerminateHungChildProcess(rph->GetHandle());
#else
- base::KillProcess(process_handle, content::RESULT_CODE_HUNG, false);
+ rph->Shutdown(content::RESULT_CODE_HUNG, false);
#endif
}
@@ -342,10 +342,7 @@ void HungRendererDialogView::ButtonPressed(
views::Button* sender, const ui::Event& event) {
if (sender == kill_button_ &&
hung_pages_table_model_->GetRenderProcessHost()) {
- base::ProcessHandle process_handle =
- hung_pages_table_model_->GetRenderProcessHost()->GetHandle();
-
- KillRendererProcess(process_handle);
+ KillRendererProcess(hung_pages_table_model_->GetRenderProcessHost());
}
}
« no previous file with comments | « chrome/browser/ui/views/hung_renderer_view.h ('k') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698