content/browser/security_exploit_browsertest.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/security_exploit_browsertest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.cc ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/security_exploit_browsertest.cc

diff --git a/content/browser/security_exploit_browsertest.cc b/content/browser/security_exploit_browsertest.cc

index 68430ad3af7deebdfc00beefeb459d6157cad184..be65a56546ac5e9274b79ce6ad3bfc3e12e99a3f 100644

--- a/content/browser/security_exploit_browsertest.cc

+++ b/content/browser/security_exploit_browsertest.cc

@@ -110,17 +110,9 @@ class SecurityExploitBrowserTest : public ContentBrowserTest {

}

};

-// Fails because the process kill on Android does not succeed.

-// http://crbug.com/433068

-#if defined(OS_ANDROID)

-#define MAYBE_SetWebUIProperty DISABLED_SetWebUIProperty

-#else

-#define MAYBE_SetWebUIProperty SetWebUIProperty

-#endif

// Ensure that we kill the renderer process if we try to give it WebUI

// properties and it doesn't have enabled WebUI bindings.

-IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest, MAYBE_SetWebUIProperty) {

+IN_PROC_BROWSER_TEST_F(SecurityExploitBrowserTest, SetWebUIProperty) {

GURL foo("http://foo.com/simple_page.html");

NavigateToURL(shell(), foo);