content/browser/child_process_security_policy_browsertest.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_security_policy_browsertest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller_browsertest.cc ('k') | content/browser/indexed_db/indexed_db_browsertest.cc » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/child_process_security_policy_browsertest.cc

diff --git a/content/browser/child_process_security_policy_browsertest.cc b/content/browser/child_process_security_policy_browsertest.cc

index b509a494706db75d00ce067384b33c51a0435780..c1e3c3959e99b6020666d495c6f9c6ab42104634 100644

--- a/content/browser/child_process_security_policy_browsertest.cc

+++ b/content/browser/child_process_security_policy_browsertest.cc

@@ -48,8 +48,7 @@ IN_PROC_BROWSER_TEST_F(ChildProcessSecurityPolicyInProcessBrowserTest, NoLeak) {

1U);

WebContents* web_contents = shell()->web_contents();

- base::KillProcess(web_contents->GetRenderProcessHost()->GetHandle(),

- RESULT_CODE_KILLED, true);

+ web_contents->GetRenderProcessHost()->Shutdown(RESULT_CODE_KILLED, true);

web_contents->GetController().Reload(true);

EXPECT_EQ(