chrome/browser/ui/views/hung_renderer_view.h - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/hung_renderer_view.h

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update comments Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/views/hung_renderer_view.cc » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/hung_renderer_view.h

diff --git a/chrome/browser/ui/views/hung_renderer_view.h b/chrome/browser/ui/views/hung_renderer_view.h

index 37264b1c9c0fd7b439fc1d490dc646d359cdce2b..27a0f66669525073d653476af1fd1121164128b5 100644

--- a/chrome/browser/ui/views/hung_renderer_view.h

+++ b/chrome/browser/ui/views/hung_renderer_view.h

@@ -105,8 +105,8 @@ class HungRendererDialogView : public views::DialogDelegateView,

static HungRendererDialogView* GetInstance();

// Platform specific function to kill the renderer process identified by the

- // handle passed in.

- static void KillRendererProcess(base::ProcessHandle process_handle);

+ // render process host passed in.

+ static void KillRendererProcess(content::RenderProcessHost* rph);

// Returns true if the frame is in the foreground.

static bool IsFrameActive(content::WebContents* contents);

« no previous file with comments | « chrome/browser/ui/browser_browsertest.cc ('k') | chrome/browser/ui/views/hung_renderer_view.cc » ('j') | content/public/browser/render_process_host.h » ('J')