Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: content/public/browser/render_process_host.h

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revive StopChildProcess and KillProcess Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/render_process_host.h
diff --git a/content/public/browser/render_process_host.h b/content/public/browser/render_process_host.h
index 4ae7f3a282a424a9853f82a850a46ef2b6549c53..2983833f6f9d93b94136df00e673b25f351c4dec 100644
--- a/content/public/browser/render_process_host.h
+++ b/content/public/browser/render_process_host.h
@@ -102,10 +102,16 @@ class CONTENT_EXPORT RenderProcessHost : public IPC::Sender,
// http://crbug.com/158595
virtual StoragePartition* GetStoragePartition() const = 0;
+ // Try to shutdown the associated renderer process forcedly, giving it the
Charlie Reis 2014/12/02 17:13:37 nit: shut down nit: drop "forcedly," instead say "
Jaekyun Seok (inactive) 2014/12/03 02:51:35 Done.
+ // specified exit code. If |wait| is true, wait for the process to be actually
+ // terminated before returning.
+ // Returns true if it was able to shut down.
+ virtual bool Shutdown(int exit_code, bool wait) = 0;
+
// Try to shutdown the associated renderer process as fast as possible.
// If this renderer has any RenderViews with unload handlers, then this
// function does nothing. The current implementation uses TerminateProcess.
Charlie Reis 2014/12/02 17:13:37 Might as well drop the "current implementation" se
Jaekyun Seok (inactive) 2014/12/03 02:51:35 Done.
- // Returns True if it was able to do fast shutdown.
+ // Returns true if it was able to do fast shutdown.
virtual bool FastShutdownIfPossible() = 0;
// Returns true if fast shutdown was started for the renderer.
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/test/browser_test_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698