content/browser/indexed_db/indexed_db_browsertest.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_browsertest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revive StopChildProcess and KillProcess Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/child_process_security_policy_browsertest.cc ('k') | content/browser/manifest/manifest_manager_host.cc » ('j') | content/public/browser/render_process_host.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_browsertest.cc

diff --git a/content/browser/indexed_db/indexed_db_browsertest.cc b/content/browser/indexed_db/indexed_db_browsertest.cc

index 871d9f50f2f3ef1763e8eb72a22ada68d72b4997..1080ad4841edfd81d3d2f9f9bee31a7088a74af2 100644

--- a/content/browser/indexed_db/indexed_db_browsertest.cc

+++ b/content/browser/indexed_db/indexed_db_browsertest.cc

@@ -686,8 +686,7 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, ConnectionsClosedOnTabClose) {

base::string16 expected_title16(ASCIIToUTF16("setVersion(3) complete"));

TitleWatcher title_watcher(new_shell->web_contents(), expected_title16);

- base::KillProcess(

- shell()->web_contents()->GetRenderProcessHost()->GetHandle(), 0, true);

+ shell()->web_contents()->GetRenderProcessHost()->Shutdown(0, true);

shell()->Close();

EXPECT_EQ(expected_title16, title_watcher.WaitAndGetTitle());