chrome/browser/extensions/extension_crash_recovery_browsertest.cc - Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 740813004: Use StopChildProcess instead of base::KillProcess to kill a renderer process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typos Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

index 072aa4d14f926538f8e3939c7aa59e37f64ca906..7243f1ca7fb0bb6e6f4d187717264c8af698d475 100644

--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

@@ -76,8 +76,8 @@ class ExtensionCrashRecoveryTestBase : public ExtensionBrowserTest {

GetBackgroundHostForExtension(extension_id);

ASSERT_TRUE(extension_host);

- base::KillProcess(extension_host->render_process_host()->GetHandle(),

- content::RESULT_CODE_KILLED, false);

+ extension_host->render_process_host()->FastShutdown(

+ content::RESULT_CODE_KILLED, false);

ASSERT_TRUE(WaitForExtensionCrash(extension_id));

ASSERT_FALSE(GetProcessManager()->

GetBackgroundHostForExtension(extension_id));

« no previous file with comments | « no previous file | chrome/browser/extensions/window_open_apitest.cc » ('j') | content/browser/renderer_host/render_process_host_impl.cc » ('J')