Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 740783004: Adding instrumentation to locate the source of jankiness. (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding instrumentation to locate the source of jankiness. Prior instrumentations showed that most of the jank for this bug comes from these lines in AboutSigninInternals::NotifyObservers scoped_ptr<base::DictionaryValue> signin_status_value = signin_status_.ToValue(client_->GetProductVersion()); Note that at least in Windows Canary, there are always 0 observers, and the value that we are calculating using a janky call is not used. I'm almost certain that the cause of jank is in VersionInfo::GetVersionStringModifier, but I'm adding this last instrumentation to be 100% sure. Reviewers, please feel free to stop me and start fixing the jank if you already know what's happening. This is a mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after. A number of similar CLs were landed, and none of them caused issues. They've helped to find and fix janky code. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers. The task gets created only in developer build and in Canary channel. BUG=422460 Committed: https://crrev.com/ff67509f135221d6caf3ce32cc0fc1e79d1ef721 Cr-Commit-Position: refs/heads/master@{#305049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/common/chrome_version_info_win.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/signin/core/browser/about_signin_internals.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vadimt
rogerta@chromium.org: Please review changes in components/signin/core/browser/about_signin_internals.cc thakis@chromium.org: Please review changes in chrome/common/chrome_version_info_win.cc
6 years, 1 month ago (2014-11-20 00:00:27 UTC) #2
Nico
chrome_version_info_win.cc lgtm
6 years, 1 month ago (2014-11-20 00:02:11 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm
6 years, 1 month ago (2014-11-20 01:35:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/740783004/1
6 years, 1 month ago (2014-11-20 15:19:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 18:49:31 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:50:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff67509f135221d6caf3ce32cc0fc1e79d1ef721
Cr-Commit-Position: refs/heads/master@{#305049}

Powered by Google App Engine
This is Rietveld 408576698