Issue 740773002: Revert "Sky: When an iframe element is removed, delete its mojo View."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 740773002: Revert "Sky: When an iframe element is removed, delete its mojo View." (Closed)

Created:
6 years, 1 month ago by Matt Perry

Modified:
6 years, 1 month ago

Reviewers:
esprehn

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Revert "Sky: When an iframe element is removed, delete its mojo View." This reverts commit 45991a3752e6a6298901eba36e7bf4cdec4d263c. It was causing flaky crashes on the bots. TBR=esprehn@chromium.org BUG=434555 Committed: https://chromium.googlesource.com/external/mojo/+/acec66c735d6a40d3da3e0e9a6ee5f278bdfe043

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
	M	sky/engine/core/html/HTMLIFrameElement.cpp	View		3 chunks	+3 lines, -6 lines	0 comments	Download
	M	sky/tests/lowlevel/iframe.sky	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 2 (1 generated)

Matt Perry

6 years, 1 month ago (2014-11-19 20:13:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
acec66c735d6a40d3da3e0e9a6ee5f278bdfe043 (presubmit successful).