Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: media/base/pipeline_unittest.cc

Issue 740663002: Relanding 'Ignore seek operations to the current time in pause state' patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/pipeline.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index 9528cf7b3b4bb40e800ffcd4ff2eb5d6eed6569b..98664ace540a6207f0acd4f11240b3b8f398681e 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -619,6 +619,9 @@ TEST_F(PipelineTest, EndedCallback) {
message_loop_.RunUntilIdle();
EXPECT_CALL(callbacks_, OnEnded());
+ // There are cases where duration is reported wrong initially, so there is
DaleCurtis 2014/12/04 02:04:41 Same comment as PipelineIntegrationTest.
Srirama 2014/12/04 03:16:46 Sorry, i couldn't get what you mean by.
DaleCurtis 2014/12/04 19:10:43 I meant don't add an EXPECT_CALL that won't always
+ // an OnDurationChange event fired again on OnEnded event if required.
+ EXPECT_CALL(callbacks_, OnDurationChange());
text_stream()->SendEosNotification();
message_loop_.RunUntilIdle();
}
« no previous file with comments | « media/base/pipeline.cc ('k') | media/blink/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698